fix microsoft/Phi-3-mini-4k-instruct crash in batch.slots[batch.slot_… #2148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…indices] Signed-off-by: Wang, Yi A <[email protected]>
sywangyi
referenced
this pull request
Jul 1, 2024
* fix: refactor post_processor logic and add test * fix: remove dev comment * fix: adjust when post_processor is overridden and improve create_post_processor
|
We can't fix it that way (The initial goal was the fix Phi3 and DeepSeek). Seems like we just need to override the processor because the one defined on the hub is wrong. https://huggingface.co/microsoft/Phi-3-mini-4k-instruct/discussions/75/files |
Narsil
reviewed
Jul 1, 2024
Narsil
approved these changes
Jul 1, 2024
glegendre01
pushed a commit
that referenced
this pull request
Jul 2, 2024
#2148) * fix microsoft/Phi-3-mini-4k-instruct crash in batch.slots[batch.slot_indices] Signed-off-by: Wang, Yi A <[email protected]> * Apply suggestions from code review --------- Signed-off-by: Wang, Yi A <[email protected]> Co-authored-by: Nicolas Patry <[email protected]>
ErikKaum
pushed a commit
that referenced
this pull request
Jul 26, 2024
#2148) * fix microsoft/Phi-3-mini-4k-instruct crash in batch.slots[batch.slot_indices] Signed-off-by: Wang, Yi A <[email protected]> * Apply suggestions from code review --------- Signed-off-by: Wang, Yi A <[email protected]> Co-authored-by: Nicolas Patry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Narsil