Skip to content

Fixed README ToC #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fixed README ToC #2196

merged 1 commit into from
Jul 9, 2024

Conversation

vinkamath
Copy link
Contributor

What does this PR do?

Fixes broken README ToC

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Narsil
Copy link
Collaborator

Narsil commented Jul 8, 2024

I fail to see what's broken about it.

https://github.com/huggingface/text-generation-inference?tab=readme-ov-file#table-of-contents
image

Could you be more specific about what's broken ?

@vinkamath
Copy link
Contributor Author

Could you be more specific about what's broken ?

The Run Mistral section has been changed to Run locally. We've added new sub-sections to Getting Started.

Copy link
Collaborator

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@Narsil Narsil merged commit f5ba9bf into huggingface:main Jul 9, 2024
ErikKaum pushed a commit that referenced this pull request Jul 26, 2024
Co-authored-by: Vinayak Kamath <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants