Skip to content

Cpu dockerimage #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Cpu dockerimage #2367

merged 1 commit into from
Aug 12, 2024

Conversation

sywangyi
Copy link
Contributor

@sywangyi sywangyi commented Aug 7, 2024

@Narsil could you please review if ci could generate cpu docker image correctly with the PR? And once the dockerimage is generated by ci. I will verify in my side.

Signed-off-by: Wang, Yi A <[email protected]>
@sywangyi
Copy link
Contributor Author

sywangyi commented Aug 7, 2024

@yao-matrix

@sywangyi
Copy link
Contributor Author

sywangyi commented Aug 7, 2024

try to resolve #2363

@Narsil
Copy link
Collaborator

Narsil commented Aug 9, 2024

This introduces a split in the intel builds, is that desired ?
Meaning 2 builds will start to exist, making it confusing for users which one to use, no ?

Also this will break naming because -intel would not be used, shouldn't we at least keep using it for either -cpu or -xpu (whichever makes more sense) ?

@sywangyi
Copy link
Contributor Author

yes, we want to a split in the intel builds, currently intel-cpu and intel xpu use difference torch and ipex.
I use label as intel-cpu, and intel-xpu, WDYT?

@Narsil
Copy link
Collaborator

Narsil commented Aug 12, 2024

I think keeping intel for intel-cpu makes more sense to me (just to keep backward compatibilty).

I'll go ahead and merge this in the meantime.

@Narsil Narsil merged commit b6bb1d5 into huggingface:main Aug 12, 2024
@sywangyi
Copy link
Contributor Author

thanks, I see docker pull ghcr.io/huggingface/text-generation-inference:latest-intel-cp release, and it can work correctly.

@sywangyi sywangyi deleted the cpu_dockerimage branch November 4, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants