Update Quantization docs and minor doc fix. #2368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikKaum
previously approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Thank you @Vaibhavs10 🚀
To me these are a clear improvement, nothing to add at this stage 👍
Vaibhavs10
commented
Aug 7, 2024
pcuenca
reviewed
Aug 7, 2024
Co-authored-by: Pedro Cuenca <[email protected]>
drbh
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates mostly from chats w/ @ErikKaum & @danieldk - feel free to suggest edits 🙏