chore: Add old V2 backend #2551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierDehaene
commented
Sep 23, 2024
Comment on lines
+119
to
129
| let mut generation_stream = self.backend.schedule(valid_request)?; | ||
|
|
||
| // Wrap generation stream to update the backend health if the stream contains an error | ||
| let final_stream = stream! { | ||
| while let Some(response) = generation_stream.next().await { | ||
| yield response.inspect_err(|_err| { | ||
| self.backend_health.store(false, Ordering::SeqCst); | ||
| }) | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
@Narsil, it seems that we removed the generation health update logic?
I add it back here.
There was a problem hiding this comment.
No idea, I don't remember removing it specifically.
tengomucho
approved these changes
Sep 23, 2024
Narsil
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.