Skip to content

Fp8 Cache condition #2611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Fp8 Cache condition #2611

merged 1 commit into from
Oct 7, 2024

Conversation

flozi00
Copy link
Contributor

@flozi00 flozi00 commented Oct 5, 2024

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Did this on mobile while reading the code base.
If I understand correctly it needs to be cuda and flash infer.
Now it would raise of cuda or flashinfer is false, not only when both are

@flozi00
Copy link
Contributor Author

flozi00 commented Oct 5, 2024

@danieldk

@danieldk
Copy link
Member

danieldk commented Oct 7, 2024

Good catch, thanks!

@danieldk danieldk merged commit 0da4df4 into huggingface:main Oct 7, 2024
@flozi00 flozi00 deleted the patch-1 branch October 7, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants