Add more functions for client to work with cookies. #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pub fn apply_to_cookie_jar(&self, jar: &mut CookieJar) { | ||
| let &SetCookie(ref cookies) = self; | ||
| for cookie in cookies.iter() { | ||
| jar.add_original(cookie.clone()) |
There was a problem hiding this comment.
Please note that I use add_original here. I do it because the header contains only raw data and:
- The data will be corrupted if we will use
encryptedorsignedjar here. - I can't imagine a situation when we need to use
deltato get this changes.
|
Hmm. Build was broken by the new |
s-panferov
force-pushed
the
feature/client-cookies
branch
from
06cb9ed to
9d9008c
Compare
|
Rebased |
|
nice, could you rebase once more, this PR includes the rust upgrade commit a second time. |
|
and also with the rebase, squash it into a single commit? |
s-panferov
force-pushed
the
feature/client-cookies
branch
from
9d9008c to
6a8864c
Compare
|
@seanmonstar done. |
seanmonstar
added a commit
that referenced
this pull request
Dec 2, 2014
Add more functions for client to work with cookies.
|
awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #155. Please CR.