feat(client): add a new Client struct with super powers #182
Conversation
| @@ -64,22 +60,20 @@ fn main() { | |||
| [Client Bench:](./benches/client.rs) | |||
|
|
|||
| ``` | |||
|
|
|||
| running 3 tests | |||
There was a problem hiding this comment.
Should be "running 2 tests"?
|
❤️ the design :) I'm not entirely certain if it does this already, but if not in the future we might want to be able to have |
| req.start().unwrap() | ||
| .send().unwrap() | ||
| .read_to_string().unwrap() | ||
| client.request(RequestOptions { |
There was a problem hiding this comment.
Instead of building this RequestOptions struct, which will break if we add fields in the future, I think it would be best if client.request() returned a builder type, that way we can add more options without breaking existing code.
|
@reem updated |
|
Can we move the |
|
Yep, that's exactly what I was working on right now. |
|
@reem like that? |
|
Yup, looks great. Rebase? |
seanmonstar
force-pushed
the
client
branch
3 times, most recently
from
0c9755b to
dfa3431
Compare
- Includes ergonomic traits like IntoUrl and IntoBody, allowing easy usage. - Client can have a RedirectPolicy. - Client can have a SslVerifier. Updated benchmarks for client. (Disabled rust-http client bench since it hangs.)
|
finally green! |
feat(client): add a new Client struct with super powers
|
\o/ |
usage.
Updated benchmarks for client. (Disabled rust-http client bench since it
hangs.)
Closes #62