-
-
Notifications
You must be signed in to change notification settings - Fork 15
Completion of if/then patterns for every if nested in blocks #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completion of if/then patterns for every if nested in blocks #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The completion.js
file is going to get huge as we add more and more completions. Is there a way we can separate the $schema
completion and the if
completion? I think we should be able to do something similar to what we're doing for diagnostics using the pubsub pattern.
Right, I've tried to do it the way diagnostics are handled in |
0a7e190
to
1026f9c
Compare
That force-push was just me rebasing on top of the refactor that I just pushed. The only change was the usage of |
1026f9c
to
2ad1588
Compare
I rebased to get dependency updates to and get the change from hyperjump-io/json-schema#65 At this point I think we just need to remove the comments and get the indentation/formatting of the completion string to look right. |
I found the Snippet Syntax that allows us to define tab completion functionality for this snippet. |
I removed the |
Right, makes more sense. I should've kept that in mind. |
Resolves #12
using
currentProperty
does not for now recognize "if" in nested blocks. So, the current approach could be changed accordingly which identifies "if" at all positions.