Skip to content

Adds bundle support to block builder #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Nov 12, 2024
Merged

Adds bundle support to block builder #8

merged 19 commits into from
Nov 12, 2024

Conversation

dylanlott
Copy link
Contributor

@dylanlott dylanlott commented Oct 31, 2024

This PR adds a BundleFetcher that the block builder uses to fetch bundles from the tx cache. It works similarly to the tx poller:

  • it requests all bundles from the cache
  • it filters out the already seen ones, keeping only the unique bundles
  • it then sends these to the block task, which ingests the bundles one by one.
    • When ingesting the bundles, right now only the txs are ingested, without respecting the set configurations for bundles, nor including the permit2 signed orders. This means that only the basic bundle functionality is implemented. Further implementation probably requires simulation work.
    • There's no specific rule to where the txs of the bundle land in the block. We are simply extending the block with the new transactions.

Closes ENG-630.

DO NOT MERGE until ENG-633 is implemented.

@dylanlott dylanlott added the enhancement New feature or request label Oct 31, 2024
@dylanlott dylanlott self-assigned this Oct 31, 2024
@Evalir Evalir self-assigned this Nov 8, 2024
@Evalir Evalir marked this pull request as ready for review November 8, 2024 16:29
@Evalir Evalir changed the title [WIP] Adds bundle support to block builder Adds bundle support to block builder Nov 8, 2024
@Evalir
Copy link
Member

Evalir commented Nov 8, 2024

Updated description and broke out tasks into separate tickets—this now implements the basic functionality to make bundle fetching / block building with it work.

* feat: caching, shareable authenticator

* fix: actually spawn builder task lmao

* chore: remove unnecesary mut selfs
@Evalir Evalir enabled auto-merge (squash) November 12, 2024 17:08
@Evalir Evalir merged commit 012b9c2 into main Nov 12, 2024
4 checks passed
@Evalir Evalir deleted the dylan/bundle-poller branch November 12, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants