fix: gas estimation for simple transfers #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
force-pushed
the
prestwich/estimation-fix
branch
from
e2b43bf to
5932673
Compare
prestwich
commented
Feb 20, 2025
| @@ -41,3 +42,37 @@ impl<Ext, Db: DatabaseRef + Sync> EvmNeedsBlock<'_, Ext, ConcurrentState<Db>> { | |||
| bundle | |||
| } | |||
| } | |||
|
|
|||
| impl<Ext, Db: DatabaseRef + Sync> EvmNeedsTx<'_, Ext, ConcurrentState<Db>> { | |||
There was a problem hiding this comment.
drive-by to add feature parity with State
prestwich
commented
Feb 20, 2025
| /// them should be done with caution, as it may lead to logic bugs. | ||
| /// | ||
| /// [`CfgEnv`]: revm::primitives::CfgEnv | ||
| pub fn env_unchecked(&self) -> &Env { |
There was a problem hiding this comment.
drive-by util functions
prestwich
commented
Feb 20, 2025
| @@ -1176,7 +1200,7 @@ impl<'a, Ext, Db: Database + DatabaseCommit, TrevmState: HasTx> Trevm<'a, Ext, D | |||
| } | |||
| } | |||
|
|
|||
| // -- HAS TX with State<Db> | |||
| // -- NEEDS TX with State<Db> | |||
Evalir
approved these changes
Feb 20, 2025
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "trevm" | |||
| version = "0.19.3" | |||
| version = "0.19.5" | |||
Co-authored-by: evalir <[email protected]>
Co-authored-by: evalir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the basic transfer estimation failed when eip2930 or eip7702 attributes were present, by underestimating the gas required.
This is an edge case, as users don't generally attach spurious info that costs money, but regularly encountered during testing things like
eth_estimateGas