feat: child db for concurrent state #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Evalir
approved these changes
Mar 3, 2025
| } | ||
| } | ||
|
|
||
| // TODO make cache aware of transitions dropping by having global transition counter. |
There was a problem hiding this comment.
this is actually reproduced from revm. And I don't think they are planning on it anytime soon.
| /// the child may be cloned AFTER this check is made, but BEFORE the child | ||
| /// is merged. In this case the function will spuriously return `Ok(())` | ||
| /// even though the merge will fail. To avoid this, ensure that the child | ||
| /// is not shared between threads when [`Self::can_merge`] is called. |
There was a problem hiding this comment.
really really far out idea that might not be worth the trouble, but what if we codify this rule into some state machine-like type
There was a problem hiding this comment.
would be possible but seems like more effort than it's worth 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows
Arc<ConcurrentState>to spawn and absorbChildDBs