Skip to content
This repository was archived by the owner on Aug 1, 2023. It is now read-only.

[DEVOPS-1120] nix-tools based build #11

Closed
wants to merge 5 commits into from
Closed

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Nov 6, 2018

Adds a nix-build of cardano-shell which uses the package set defined in cardano-prelude/snapshot.yaml instead of a package set from nixpkgs.

This is based on nix-tools rather than stack2nix.

It uses the common library code from iohk-nix.

@rvl rvl added the wip Work In Progress label Nov 6, 2018
@rvl rvl self-assigned this Nov 6, 2018
@rvl rvl requested review from erikd and ksaric as code owners November 6, 2018 01:07
@angerman
Copy link

angerman commented Nov 6, 2018

@rvl This seems to build for me now:

nix-build nix/pkgs.nix -A cardano-shell.components.exes.cardano-shell-exe -j8  

nix-tools needs some work so that stack-to-nix produces the proper files. It also need some test aggregation, e.g. build cardano-shell.components.tests as well as the tests of dependencies.

NOTE: we use nix/pkgs.nix as the base expression. I haven't had time to fix default.nix and the others.

angerman
angerman previously approved these changes Nov 6, 2018
@angerman
Copy link

angerman commented Nov 6, 2018

nix-build . -A cardano-shell.components.exes.cardano-shell-exe -j8

seems to produce ./result/bin/cardano-shell-exe; which prints Test.

@angerman
Copy link

angerman commented Nov 9, 2018

This will now fail, as the test-suite is rigged to fail.

@rvl rvl force-pushed the devops-1120-nix-tools branch from dcf6166 to 07da1a9 Compare November 14, 2018 04:45
@rvl rvl force-pushed the devops-1120-nix-tools branch 4 times, most recently from 1340b86 to 3d3b66d Compare December 12, 2018 06:02
@rvl rvl changed the title WIP [DEVOPS-1120] nix-tools based build [DEVOPS-1120] nix-tools based build Dec 12, 2018
@rvl rvl removed the wip Work In Progress label Dec 12, 2018
@rvl rvl force-pushed the devops-1120-nix-tools branch 2 times, most recently from ca3b190 to f82228d Compare December 13, 2018 00:31
@rvl rvl force-pushed the devops-1120-nix-tools branch from f82228d to c10c088 Compare December 21, 2018 01:12
@rvl
Copy link
Contributor Author

rvl commented Dec 21, 2018

Rebased on latest develop.

@ksaric Could you please review? This will change the build and package regeneration process (README.md has been updated).

shell.nix Outdated
@@ -1 +1 @@
(import ./release.nix).cardano-shell.env
(import ./release.nix).cardano-shell

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worky worky?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worky... will put it back to WIP until we can sort this out.

@rvl rvl force-pushed the devops-1120-nix-tools branch from 86abbac to b9a9feb Compare February 1, 2019 10:28
iohk-bors bot added a commit to input-output-hk/iohk-ops that referenced this pull request Feb 1, 2019
524: [DEVOPS-1120] jobsets: add cardano-shell r=rvl a=rvl

Tested with:

    jq . < $(nix-build --no-out-link jobsets/default.nix)

See: input-output-hk/cardano-shell#11


Co-authored-by: Rodney Lorrimar <[email protected]>
@CodiePP
Copy link
Contributor

CodiePP commented Mar 29, 2019

this nix setup here looks like very much outdated. could this be upgraded to the latest and finest of nix-tools, please? @angerman @jbgi

@rvl rvl force-pushed the devops-1120-nix-tools branch from b9a9feb to 09db97a Compare April 2, 2019 23:38
@ksaric
Copy link
Contributor

ksaric commented May 30, 2019

@rvl Closing this one. If somebody needs something from here they can reopen/cherry pick.

@ksaric ksaric closed this May 30, 2019
@ksaric ksaric deleted the devops-1120-nix-tools branch June 5, 2019 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
wip Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants