This repository was archived by the owner on Aug 1, 2023. It is now read-only.
[GH-144] Rethrow cought exceptions to check if the application is throwing them. #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikd
approved these changes
May 9, 2019
|
Seems sensible, especially to do this now rather than later. Most exceptions should be caught as close as possible to their source and either be handled in an appropriate manner or returned back up the stack as |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#144
This should be released to test with
validate-mainnet.Also, other exceptions should be noticed.
After confirming the exception is not swallowed, we can continue.