Skip to content
This repository was archived by the owner on Aug 1, 2023. It is now read-only.

[GH-86] Add one-pager pdf #146

Merged
merged 1 commit into from
May 13, 2019
Merged

[GH-86] Add one-pager pdf #146

merged 1 commit into from
May 13, 2019

Conversation

HirotoShioi
Copy link
Contributor

This PR introduces one-pager pdf file for cardano-shell.
#86

@HirotoShioi HirotoShioi requested review from erikd and ksaric as code owners May 10, 2019 04:51
@HirotoShioi HirotoShioi self-assigned this May 10, 2019
@HirotoShioi HirotoShioi changed the title Add one-pager pdf [GH-86] Add one-pager pdf May 10, 2019
@erikd
Copy link
Member

erikd commented May 10, 2019

PDF is a binary format that cannot be meaningfully diffed or otherwise handled the way we handle source code. That means all we can ever provide is snapshots of this file, rather than any meaninigful information as to how it has changed over time.

I would therefore suggest that we do not commit the PDF file itself to git, but rather the hopefully human readable source file, eg markdown or LaTeX.

@HirotoShioi
Copy link
Contributor Author

@erikd I agree with you. I've reported this to the @CodiePP and he'll look into it.

@CodiePP CodiePP self-requested a review May 13, 2019 11:42
Copy link
Contributor

@CodiePP CodiePP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will add a ODP version of the source document

@CodiePP CodiePP merged commit 1b5195b into develop May 13, 2019
@HirotoShioi HirotoShioi deleted the hiroto/GH-86 branch May 14, 2019 05:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants