This repository was archived by the owner on Aug 1, 2023. It is now read-only.
Update document #148
Merged
Update document #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HirotoShioi When you see a failure, you can take a look at the "Details" and try to figure out why is it failing. |
ksaric
suggested changes
May 16, 2019
specs/CardanoShellSpec.lhs
Outdated
| @@ -207,6 +207,9 @@ When the \textit{Daedalus} calls and starts the \textit{Node}, it also opens up | |||
| First, the \textit{Node} sends the message \textbf{Started} back to the \textit{Daedalus} to inform him that the communication can begin. | |||
| After that, \textit{Daedalus} sends the message \textbf{QueryPort} to the \textit{Node}, and the \textit{Node} responds with the free port it found using \textbf{ReplyPort PORTNUM} that is going to be used for starting the HTTP "server" serving the \textit{JSON API} which they can then use to communicate further.\\ | |||
|
|
|||
| Not only does the \textit{Node} responds to the message, but it can also perform some IO actions depending on the message sent from the client. | |||
| For instance, you can have the node to start an new process when the client sends \textbf{Started} or have it so that node will kill its thread/process when it responds with \textbf{ReplyPort PORTNUM}.\\ | |||
There was a problem hiding this comment.
start an new process - start a new process.
"you can have the node to start an new process when the client sends \textbf{Started} or have it so that node will kill its thread/process when it " - what does this mean? Maybe an example where the response is an action called "FetchInfo SystemInfo" where the client needs to fetch the client info and return it to the server. That would require IO.
|
You can rebase on top of #171 (develop). |
added 4 commits
May 30, 2019 12:14
ksaric
approved these changes
May 30, 2019
| @@ -1,6 +1,6 @@ | |||
| let | |||
| # adding the haskell environment for running lhs2tex | |||
| pkgs = import (import ./../nixpkgs.nix) { config = import ./../config.nix; }; | |||
| pkgs = import (import ./../nixpkgs.nix) { config = import ./../default.nix; }; | |||
There was a problem hiding this comment.
I'm not sure if we even need nixpkgs.nix but this is not required to be the bleeding edge anyway, so it's good.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated NodeIPC documentation to include description to include about extended message handling.