Skip to content
This repository was archived by the owner on Aug 1, 2023. It is now read-only.

[GH-99] T5.1.1 simplified logging feature #159

Merged
merged 2 commits into from
May 20, 2019
Merged

[GH-99] T5.1.1 simplified logging feature #159

merged 2 commits into from
May 20, 2019

Conversation

CodiePP
Copy link
Contributor

@CodiePP CodiePP commented May 16, 2019

Signed-off-by: Alexander Diemand [email protected]

  • the bracket functions do not require access to the configuration.
  • export more bracket functions.

@CodiePP CodiePP requested a review from ksaric May 16, 2019 16:09
@CodiePP CodiePP requested a review from erikd as a code owner May 16, 2019 16:09
@CodiePP CodiePP self-assigned this May 16, 2019
ksaric
ksaric approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@ksaric ksaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the bracket names, they don't really mean much to me, but the rest looks good.

@CodiePP CodiePP merged commit 4e9651d into develop May 20, 2019
@ksaric ksaric deleted the logging-feature-simplified branch May 21, 2019 10:48
@CodiePP CodiePP mentioned this pull request May 21, 2019
Closed
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ksaric ksaric ksaric approved these changes

@erikd erikd Awaiting requested review from erikd

Assignees

@CodiePP CodiePP

Labels
None yet
Projects
None yet
Milestone
NOD005 Minimal integration with Node ...
Development

Successfully merging this pull request may close these issues.
2 participants
@CodiePP @ksaric