This repository was archived by the owner on Aug 1, 2023. It is now read-only.
Fix various CardanoConfiguration types
#168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/fix-cardano-config
branch
from
5cce66b to
e3e442a
Compare
Jimbo4350
changed the title
coRequiresNetworkMagic config valueCardanoConfiguration types
Jimbo4350
force-pushed
the
jordan/fix-cardano-config
branch
11 times, most recently
from
d9e5218 to
93c601a
Compare
|
You can rebase on top of #171 (develop). |
Jimbo4350
force-pushed
the
jordan/fix-cardano-config
branch
from
93c601a to
210eebe
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing
CardanoConfigurationto see if we require aNetworkMagicvalue, we look for either"RequiresMagic"(for testnet) or"RequiresNoMagic"(for mainnet or staging).Change other types in
CardanoConfigurationto match their corresponding types incardano-ledger.