Skip to content

Fix filtering package in root of project #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2021
Merged

Conversation

hamishmack
Copy link
Collaborator

When a package is not in a subdirectory, but instead
in the root of the project the cleaning of the package
source was broken.

This might explain why some cabal.project file
based projects might also see be affected by #1013.

When a package is not in a subdirectory, but instead
in the root of the project the cleaning of the package
source was broken.

This might explain why some `cabal.project` file
based projects might also see be affected by #1013.
@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Feb 14, 2021
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 14, 2021

@hamishmack hamishmack requested a review from angerman February 14, 2021 22:45
Copy link
Collaborator

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hamishmack hamishmack merged commit 39560d4 into master Feb 15, 2021
@iohk-bors iohk-bors bot deleted the hkm/fix-package-in-root branch February 15, 2021 03:37
booniepepper pushed a commit to booniepepper/haskell.nix that referenced this pull request Feb 4, 2022
When a package is not in a subdirectory, but instead
in the root of the project the cleaning of the package
source was broken.

This might explain why some `cabal.project` file
based projects might also see be affected by input-output-hk#1013.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants