Respect dontStrip
#110
Merged
Respect dontStrip
#110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like it will work. Could there be test cases which check executables are stripped or not depending on the option? |
|
I've just locally confimed this will work. I'm trying my luck with a test case now. |
|
I fail to get anywhere with a proper testcase for this. As such I'll just go and merge this. While |
andreabedini
pushed a commit
to andreabedini/haskell.nix
that referenced
this pull request
Sep 14, 2022
…#110) If a package is local to the project, but none of the components are in the plan, then there will be an empty `components` attribute and no `component-name`. Currently this causes an error as we look for a `component-name` when the `components` attribute is empty. This change will make it so that we only look for the `component-name` when there is no `components` attribute at all.
andreabedini
pushed a commit
to andreabedini/haskell.nix
that referenced
this pull request
Sep 14, 2022
…#110) If a package is local to the project, but none of the components are in the plan, then there will be an empty `components` attribute and no `component-name`. Currently this causes an error as we look for a `component-name` when the `components` attribute is empty. This change will make it so that we only look for the `component-name` when there is no `components` attribute at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.