Skip to content

Update stack.yaml #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 7, 2019
Merged

Update stack.yaml #112

merged 5 commits into from
May 7, 2019

Conversation

angerman
Copy link
Collaborator

No description provided.

@angerman
Copy link
Collaborator Author

This still needs stack-to-nix to run.

Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

# cabal-to-nix test-haddock.cabal > test-haddock.nix
pkg-def = import ./plan.nix;
pkgSet = mkCabalProjectPkgSet {
pkg-def = import ./pkgs.nix;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be plan-pkgs, similar to how mkStackPkgSet has stack-pkgs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, thanks, I forgot to update them all ...

@rvl rvl force-pushed the angerman/fix-stack-tests branch from a14d639 to c78e90e Compare May 7, 2019 06:01
And update it for new versions of plan-to-nix.
@rvl rvl force-pushed the angerman/fix-stack-tests branch from c78e90e to 38b302d Compare May 7, 2019 06:06
@angerman
Copy link
Collaborator Author

angerman commented May 7, 2019

I'm quite confident this will work. And I believe travis is hopelessly overwhelmed with the amount of package it needs to build.

@angerman angerman merged commit 515c88e into master May 7, 2019
@angerman angerman deleted the angerman/fix-stack-tests branch May 7, 2019 07:31
@angerman angerman mentioned this pull request May 7, 2019
@rvl
Copy link
Contributor

rvl commented May 7, 2019

Thanks for the fix. It works on Buildkite and it works locally. Travis is a U+1F4A9.

@angerman
Copy link
Collaborator Author

angerman commented May 8, 2019

We may be able to get around travis by using cachix + watching, but I wonder if that's really the way forward. Maybe we just need to heat up the cache with our own hydra instance. Or just move off of travis altogether.

@rvl
Copy link
Contributor

rvl commented May 11, 2019

Any PR which touches the component builder probably won't finish in Travis because it needs to rebuild all of the haskell packages. Buildkite works well, but we need to enable the setting which makes the build page public.

@angerman
Copy link
Collaborator Author

Using cachix with watching would cause intermediate products to be uploaded to cachix, it would likely require to restart the Travis job.

If we can just get the badges from buildkite or hydra, let’s trash Travis.

andreabedini pushed a commit to andreabedini/haskell.nix that referenced this pull request Sep 14, 2022
andreabedini pushed a commit to andreabedini/haskell.nix that referenced this pull request Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants