Skip to content

Add mapping from util -> utillinux #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2019
Merged

Add mapping from util -> utillinux #118

merged 1 commit into from
May 10, 2019

Conversation

luke-clifton
Copy link
Contributor

@luke-clifton luke-clifton commented May 10, 2019 •
edited
Loading

@luke-clifton
Copy link
Contributor Author

(Failures are due to the build taking too long)

@angerman
Copy link
Collaborator

lgtm.

@angerman angerman merged commit b0a05cd into input-output-hk:master May 10, 2019
andreabedini pushed a commit to andreabedini/haskell.nix that referenced this pull request Sep 14, 2022
@hamishmack
Use nix instead of json in output of hackage-to-nix (input-output-hk#118
2f76474 
)

We have been using `readFile` and `fromJSON` to read a `.json` a 60MB .json file.  This change puts the information contained in the json file into `.nix` files that are imported when needed (rather than all at once).  This seems to save around 1s at eval time.

Tested with:
```
time nix-instantiate -E '(import ./. {}).pkgs-unstable.haskell-nix.tool "ghc8107" "hello" {}'
time nix-instantiate -E '(import ./. {}).pkgs-unstable.haskell-nix.tool "ghc8107" "haskell-language-server" {}'
```

See also input-output-hk#1574
andreabedini pushed a commit to andreabedini/haskell.nix that referenced this pull request Sep 14, 2022
@hamishmack
Use nix instead of json in output of hackage-to-nix (input-output-hk#118
555d57e 
)

We have been using `readFile` and `fromJSON` to read a `.json` a 60MB .json file.  This change puts the information contained in the json file into `.nix` files that are imported when needed (rather than all at once).  This seems to save around 1s at eval time.

Tested with:
```
time nix-instantiate -E '(import ./. {}).pkgs-unstable.haskell-nix.tool "ghc8107" "hello" {}'
time nix-instantiate -E '(import ./. {}).pkgs-unstable.haskell-nix.tool "ghc8107" "haskell-language-server" {}'
```

See also input-output-hk#1574
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luke-clifton @angerman