Skip to content

builder: Add haddock and hoogle #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2019
Merged

builder: Add haddock and hoogle #13

merged 2 commits into from
Feb 12, 2019

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Jan 10, 2019

Adds haddock building to the component builder. This can be accessed with the pkgSet.config.hsPkgs.PACKAGE.components.library.doc attribute.

Hoogle databases are built for each component, but there are no combined Hoogle databases generated yet. That can be done in another PR.

@rvl rvl mentioned this pull request Jan 10, 2019
4 tasks
@rvl rvl force-pushed the builder-haddock2 branch 3 times, most recently from 3f8c7e9 to 626c204 Compare February 5, 2019 01:05
@rvl rvl force-pushed the builder-haddock2 branch from 626c204 to 08c5a2d Compare February 5, 2019 01:31
@rvl rvl changed the title WIP builder: Add haddock and hoogle builder: Add haddock and hoogle Feb 5, 2019
@rvl rvl force-pushed the builder-haddock2 branch from 08c5a2d to 1fe92fd Compare February 8, 2019 01:43
Copy link
Collaborator

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -61,6 +61,9 @@ with haskellLib;
if componentId.ctype == "all" then ""
else "${componentId.ctype}:${componentId.cname}";

# Remove null or empty values from an attrset.
optionalHooks = lib.filterAttrs (_: hook: hook != null && hook != "");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nifty!

@ElvishJerricco
Copy link
Contributor

@angerman fair enough, but failing silently on real haddock failure is the worst option to me for sure.

@rvl rvl force-pushed the builder-haddock2 branch from 6c73e27 to 8ad8731 Compare February 12, 2019 02:46
@rvl
Copy link
Contributor Author

rvl commented Feb 12, 2019

I have squashed and rebased on master, and opened issue #50 for automatically disabling doHaddock.

@rvl rvl merged commit 2520ce0 into master Feb 12, 2019
@rvl rvl deleted the builder-haddock2 branch February 12, 2019 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants