-
Notifications
You must be signed in to change notification settings - Fork 247
builder: Add haddock and hoogle #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3f8c7e9
to
626c204
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -61,6 +61,9 @@ with haskellLib; | |||
if componentId.ctype == "all" then "" | |||
else "${componentId.ctype}:${componentId.cname}"; | |||
|
|||
# Remove null or empty values from an attrset. | |||
optionalHooks = lib.filterAttrs (_: hook: hook != null && hook != ""); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nifty!
@angerman fair enough, but failing silently on real haddock failure is the worst option to me for sure. |
6c73e27
to
8ad8731
Compare
I have squashed and rebased on master, and opened issue #50 for automatically disabling |
Adds haddock building to the component builder. This can be accessed with the
pkgSet.config.hsPkgs.PACKAGE.components.library.doc
attribute.Hoogle databases are built for each component, but there are no combined Hoogle databases generated yet. That can be done in another PR.