Skip to content

added icu-i18n mapping #1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Conversation

paumr
Copy link
Contributor

@paumr paumr commented Apr 22, 2022

this mapping should solve build-problems with https://github.com/haskell/text-icu

@michaelpj
Copy link
Collaborator

Just checking, but you're using a haskell.nix that contains #1395, right?

@paumr
Copy link
Contributor Author

paumr commented Apr 22, 2022

Hi,
yes, this PR was included in my pinned state.
However if you add text-icu as a cabal dependency this error gets thrown:

error: The pkg-conf packages does not contain the package: icu-i18n (pkg-conf dependency).
       You may need to augment the pkg-conf package mapping in haskell.nix so that it can be found.

Mentioned PR would have fixed this issue if this line:
pkgconfPkgs = import ./lib/pkgconf-nixpkgs-map.nix pkgs;

would be something similair to this:

        pkgconfPkgs = import ./lib/pkgconf-nixpkgs-map.nix (import ./lib/system-pkgs.nix pkgs);

@michaelpj
Copy link
Collaborator

Great, just checking. If you're still seeing complaints about it then this does sound like the right fix.

@michaelpj michaelpj merged commit df89dc9 into input-output-hk:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants