-
Notifications
You must be signed in to change notification settings - Fork 247
default enableSeparateDataOutput to true #1476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default enableSeparateDataOutput to true #1476
Conversation
Fixes things like #899 (comment) and #1473 (comment). There's no downside to this I can think of. |
bors try |
I think this will change |
tryTimed out. |
bors try |
tryTimed out. |
bors try |
tryBuild succeeded: |
bors try |
tryTimed out. |
@hamishmack simply to cure my own ignorance, what exactly does this do?
Or at the very least, where can I read about what the ifdLevel stuff in haskell.nix does? |
It looks like the ifdLevel 3 jobset has now built on hydra so this should be safe to merge now. Because of the recursive nature of Haskell.nix (GHC is used to build the tools used to build GHC and work out what cabal components exist), some changes will result in hydra rebuilding the world when it tries to work out what should be in jobset (eval time). ifdLevel is a way we can limit the jobset to just the jobs we know about with the help of materialised nix (pre-calculated output of the tools that cause bootstrap issues). |
Hydra build results are here https://hydra.iohk.io/jobset/Cardano/haskell-nix-bors-trying |
If #1477 (comment) is true, I'm surprised we didn't have any failures in the jobset 🤔 I guess it isn't a problem? |
Ignore me, that comment is about stripping, not data outputs. |
No description provided.