Skip to content

default enableSeparateDataOutput to true #1476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TravisWhitaker
Copy link
Contributor

No description provided.

@TravisWhitaker
Copy link
Contributor Author

Fixes things like #899 (comment) and #1473 (comment). There's no downside to this I can think of.

@hamishmack
Copy link
Collaborator

bors try

iohk-bors bot added a commit that referenced this pull request May 19, 2022
@hamishmack
Copy link
Collaborator

I think this will change alex and happy and therefor rebuild all the GHCs. So I've taken it back to ifdLevel 0 to avoid doing it during hydra eval.

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 20, 2022

try

Timed out.

@hamishmack
Copy link
Collaborator

bors try

iohk-bors bot added a commit that referenced this pull request May 21, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 21, 2022

try

Timed out.

@hamishmack
Copy link
Collaborator

bors try

iohk-bors bot added a commit that referenced this pull request May 22, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 22, 2022

@hamishmack
Copy link
Collaborator

bors try

iohk-bors bot added a commit that referenced this pull request May 22, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 22, 2022

try

Timed out.

@TravisWhitaker
Copy link
Contributor Author

@hamishmack simply to cure my own ignorance, what exactly does this do?

So I've taken it back to ifdLevel 0 to avoid doing it during hydra eval.

Or at the very least, where can I read about what the ifdLevel stuff in haskell.nix does?

@hamishmack
Copy link
Collaborator

It looks like the ifdLevel 3 jobset has now built on hydra so this should be safe to merge now.

Because of the recursive nature of Haskell.nix (GHC is used to build the tools used to build GHC and work out what cabal components exist), some changes will result in hydra rebuilding the world when it tries to work out what should be in jobset (eval time). ifdLevel is a way we can limit the jobset to just the jobs we know about with the help of materialised nix (pre-calculated output of the tools that cause bootstrap issues).

@hamishmack hamishmack merged commit 449d80f into input-output-hk:master May 24, 2022
@hamishmack
Copy link
Collaborator

Hydra build results are here https://hydra.iohk.io/jobset/Cardano/haskell-nix-bors-trying

@michaelpj
Copy link
Collaborator

If #1477 (comment) is true, I'm surprised we didn't have any failures in the jobset 🤔 I guess it isn't a problem?

@michaelpj
Copy link
Collaborator

Ignore me, that comment is about stripping, not data outputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants