-
Notifications
You must be signed in to change notification settings - Fork 247
Update HPC for better compatibility with large projects #1484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for pursuing this upstream! Future users will thank you :) |
https://gitlab.haskell.org/ghc/ghc/-/merge_requests/8194 has been merged |
Nice work! I guess we still either need to pull in the patch or else make the coverage code conditional since otherwise it will stop working for older GHCs? |
I have merged the latest changes from master and refactored the code so that it puts all the args in a single response file. I also reenabled two of the tests that had been disabled and updated them for changes that were made on master. For now I have included the patch as a ghc patch, but we can potentially drop that if/when hpc is updated in hackage. You can test
|
bors try |
tryTimed out. |
bors try |
1 similar comment
bors try |
tryAlready running a review |
bors try- |
bors try |
tryBuild failed: |
bors try- |
We should be able to merge these without risking breaking existing coverage reports. Then we can merge #1484 once we are happy it is working.
# Conflicts: # test/coverage/default.nix
bors try |
tryBuild succeeded: |
I'm going to merge this because code coverage seems pretty broken in master and this at least works for the smaller projects I have tests. I am worried that we removed this. Unfortunately every time I try to build |
With large projects HPC can produce an
argument list too long
error: NixOS/nix#5593This can be avoided by passing arguments to HPC as Response Files: https://gcc.gnu.org/wiki/Response_Files
Needs https://gitlab.haskell.org/ghc/ghc/-/merge_requests/8194 and a new release of HPC to Hackage
Follows #1464 (see #1464 (comment))