Skip to content

Add ghcWithPackages and ghcWithHoogle to hsPkgs #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2019
Merged

Conversation

rvl
Copy link
Contributor

@rvl rvl commented May 27, 2019

These functions are like in nixpkgs haskellPackages. They let you select packages from a larger package set and easily get a shell. The difference between ghcWithPackages and shellFor is that ghcWithPackages provides the packages, but shellFor provides the dependencies of the packages.

Depends on #147 being merged first.

@rvl rvl added the enhancement New feature or request label May 27, 2019
@rvl rvl self-assigned this May 27, 2019
@rvl rvl mentioned this pull request May 27, 2019
Copy link
Collaborator

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.


meta.platforms = platforms.all;
passthru = {
# Used for testing externally with nix-shell (../tests.sh).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-shell (../tests.sh)? Shouldn't that be nix-shell test/snapshots/default.nix? I'm a bit confused by that comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it -- the comment doesn't apply for this test because it's not one of the impure tests.sh test cases.

@rvl rvl force-pushed the rvl/ghc-with-packages branch from 1d5c05f to c7ec1a4 Compare May 27, 2019 03:49
@rvl rvl added the DO NOT MERGE Code is broken, or waiting for a dependency label May 27, 2019
@rvl rvl force-pushed the rvl/ghc-with-packages branch from c7ec1a4 to 82ee913 Compare May 28, 2019 01:06
@rvl rvl changed the base branch from rvl/hoogle-index to master May 28, 2019 01:06
@rvl rvl removed the DO NOT MERGE Code is broken, or waiting for a dependency label May 28, 2019
@rvl rvl force-pushed the rvl/ghc-with-packages branch from 82ee913 to 656ed3f Compare May 28, 2019 22:44
@rvl rvl force-pushed the rvl/ghc-with-packages branch from 656ed3f to 87c888d Compare June 6, 2019 01:50
@rvl rvl force-pushed the rvl/ghc-with-packages branch from 87c888d to f6b17d1 Compare June 21, 2019 12:22
@rvl rvl merged commit 0663a9c into master Jun 21, 2019
@rvl rvl deleted the rvl/ghc-with-packages branch June 21, 2019 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants