Add flake support to hix #1572

hamishmack · 2022-08-02T09:14:20Z

This adds support for using nix flakes commands with hix. This is done by creating a hidden .hix-flake directory and passing the source in using --override-input.

It also includes a hix init command to add a flake.nix and nix/hix.nix configuration file.

This adds support for using nix flakes commands with hix. This is done by creating a hidden `.hix-flake` directory and passing the source in using `--override-input`. It also includes a `hix init` command to add a `flake.nix` and `nix/hix.nix` configuration file.

yvan-sraka

LGTM! With few comments/suggestions, I am currently failing to fully test to build hello example project…

yvan-sraka · 2022-08-03T11:51:28Z

docs/tutorials/getting-started-hix.md

-* Making `flake` and `non flake` configurations to check `haskell.nix`
-  treats them the same.
-
-## Installing Nix


Maybe we can add a small n.b. to remind user that hix require having nix in PATH with experimental-features = [ "nix-command" "flakes" ]; enabled?

yvan-sraka · 2022-08-03T11:59:46Z

docs/tutorials/getting-started-hix.md

-```
-niv init
-niv add input-output-hk/haskell.nix -n haskellNix
+nix run github:input-output-hk/haskell.nix#hix -- init


I tested it using:

nix run "github:input-output-hk/haskell.nix/hkm/hix-flake#hix" -- init

zsh will complain if nix run argument not enclosed in quotes:

zsh: no matches found: github:input-output-hk/haskell.nix/hkm/hix-flake#hix

I just discover that's not default zsh who complain when argument contains : not enclosed in quotes, that's the GRML config I'm using …

yvan-sraka · 2022-08-03T12:05:00Z

hix/default.nix

+          cp $HIX_NIX nix/hix.nix
+          echo '`nix/hix.nix` project configuation:'
+        fi
+        cat nix/hix.nix


I suggest replacing cat by ${pkgs.bat}/bin/bat for fancy nix syntax highlighting.

yvan-sraka · 2022-08-03T12:05:58Z

hix/init/flake.nix

+      });
+
+  # --- Flake Local Nix Configuration ----------------------------
+  nixConfig = {


Maybe a comment here to introduce binary cache to the user and let them eventually opt out?

I'll add a comment, but nix should give the user an option not to add the cache when they build it.

yvan-sraka · 2022-08-03T12:09:11Z

hix/project/flake.nix

@@ -0,0 +1,30 @@
+{


It was unclear to me at first sight what was the difference between this file and hix/project/flake.nix

yvan-sraka · 2022-08-03T12:10:27Z

docs/tutorials/getting-started-hix.md

-niv init
-niv add input-output-hk/haskell.nix -n haskellNix
+nix run github:input-output-hk/haskell.nix#hix -- init
+nix develop


All nix commands fail on my computer: error: getting status of '/nix/store/m5kk00h3yvjbyw4frcf00hzaigf0p7p0-source/hello-1.0.0.2': No such file or directory

My bad, hello-1.0.0.2 folder was in another flake subdirectory and I guess direnv mess a bit with dev shells … now I have this issue:

yvan@X230 ~/IOHK/hello-1.0.0.2 % nix develop warning: Using saved setting for 'allow-import-from-derivation = true' from ~/.local/share/nix/trusted-settings.json. warning: Using saved setting for 'extra-substituters = https://cache.iog.io' from ~/.local/share/nix/trusted-settings.json. warning: Using saved setting for 'extra-trusted-public-keys = hydra.iohk.io:f/Ea+s+dFdN+3Y/G+FDgSq+a5NEWhJGzdjvKNGv0/EQ=' from ~/.local/share/nix/trusted-settings.json. error: The option `crossPlatforms' does not exist. Definition values: - In `<unknown-file>': <function> (use '--show-trace' to show detailed location information)

Full log with --show-trace:

error: The option `crossPlatforms' does not exist. Definition values: - In `<unknown-file>': <function> … while evaluating the attribute 'config' at /nix/store/l4ysisamwr0jdf6w2za4zygj9ajlf0wb-source/lib/modules.nix:357:9: 356| options = checked options; 357| config = checked (removeAttrs config [ "_module" ]); | ^ 358| _module = checked (config._module); … while evaluating 'hasSuffix' at /nix/store/l4ysisamwr0jdf6w2za4zygj9ajlf0wb-source/lib/strings.nix:235:5: 234| # Input string 235| content: | ^ 236| let … from call site at /nix/store/im0h1rigra4mw84y1ml8k2mr6ryjrpdc-source/overlays/haskell.nix:839:16: 838| in 839| if final.lib.hasSuffix ".yaml" selectedFileName | ^ 840| then stackProject' ([ … while evaluating 'project'' at /nix/store/im0h1rigra4mw84y1ml8k2mr6ryjrpdc-source/overlays/haskell.nix:811:20: 810| # used (as it will use a default `cabal.project`). 811| project' = projectModule: | ^ 812| let … from call site at /nix/store/im0h1rigra4mw84y1ml8k2mr6ryjrpdc-source/overlays/haskell.nix:852:33: 851| # for `cabalPackage` and `stackPackage`. 852| project = args: let p = project' args; | ^ 853| in p.hsPkgs // p; … while evaluating 'project' at /nix/store/im0h1rigra4mw84y1ml8k2mr6ryjrpdc-source/overlays/haskell.nix:852:19: 851| # for `cabalPackage` and `stackPackage`. 852| project = args: let p = project' args; | ^ 853| in p.hsPkgs // p; … from call site at /nix/store/im0h1rigra4mw84y1ml8k2mr6ryjrpdc-source/overlays/hix.nix:38:8: 37| projectDefaults = importDefaults (toString (src.origSrcSubDir or src) + "/nix/hix.nix"); 38| in final.haskell-nix.project [ | ^ 39| (import ../modules/hix-project.nix) … while evaluating 'project' at /nix/store/im0h1rigra4mw84y1ml8k2mr6ryjrpdc-source/overlays/hix.nix:3:5: 2| project = 3| { src | ^ 4| , userDefaults ? {} … from call site at /nix/store/07ym39kzdnn7h45zz6v78286d3vs1sax-source/flake.nix:19:15: 18| hixProject = 19| final.haskell-nix.hix.project { | ^ 20| src = ./.; … while evaluating the attribute 'hixProject.flake' at /nix/store/07ym39kzdnn7h45zz6v78286d3vs1sax-source/flake.nix:18:13: 17| (final: prev: { 18| hixProject = | ^ 19| final.haskell-nix.hix.project { … while evaluating anonymous lambda at /nix/store/07ym39kzdnn7h45zz6v78286d3vs1sax-source/flake.nix:14:52: 13| in 14| flake-utils.lib.eachSystem supportedSystems (system: | ^ 15| let … from call site at /nix/store/0zdncmv2n5sncs0sdphvggc61ix1fpsm-source/default.nix:128:17: 127| let 128| ret = f system; | ^ 129| op = attrs: key: … while evaluating 'op' at /nix/store/0zdncmv2n5sncs0sdphvggc61ix1fpsm-source/default.nix:126:19: 125| # Merge together the outputs for all systems. 126| op = attrs: system: | ^ 127| let … from call site at /nix/store/0zdncmv2n5sncs0sdphvggc61ix1fpsm-source/default.nix:144:5: 143| in 144| builtins.foldl' op { } systems | ^ 145| ; … while evaluating 'eachSystem' at /nix/store/0zdncmv2n5sncs0sdphvggc61ix1fpsm-source/default.nix:98:25: 97| # 98| eachSystem = systems: f: | ^ 99| let … from call site at /nix/store/07ym39kzdnn7h45zz6v78286d3vs1sax-source/flake.nix:14:7: 13| in 14| flake-utils.lib.eachSystem supportedSystems (system: | ^ 15| let … while evaluating 'outputs' at /nix/store/07ym39kzdnn7h45zz6v78286d3vs1sax-source/flake.nix:5:13: 4| inputs.flake-utils.url = "github:numtide/flake-utils"; 5| outputs = { self, nixpkgs, flake-utils, haskellNix }: | ^ 6| let … from call site at «string»:45:21: 44| 45| outputs = flake.outputs (inputs // { self = result; }); | ^ 46| … while evaluating anonymous lambda at «string»:10:13: 9| builtins.mapAttrs 10| (key: node: | ^ 11| let … from call site … while evaluating anonymous lambda at «string»:2:23: 1| 2| lockFileStr: rootSrc: rootSubdir: | ^ 3| … from call site

I forgot to say when testing this you need to also pass something to point haskellNix to the PR branch. Something like:

nix develop --override-input haskellNix "github:input-output-hk/haskell.nix/hkm/hix-flake"

I confirm that everything works as expected :)

hamishmack requested a review from yvan-sraka August 2, 2022 09:15

yvan-sraka approved these changes Aug 3, 2022

View reviewed changes

hamishmack added 2 commits August 4, 2022 20:09

Merge remote-tracking branch 'origin/master' into hkm/hix-flake

1a25751

Code review changes

b7277d5

hamishmack merged commit 05c0555 into master Aug 4, 2022

iohk-bors bot deleted the hkm/hix-flake branch August 4, 2022 22:17

This was referenced Aug 15, 2022

hix flake support #1551

Closed

hix init #1552

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add flake support to hix #1572

Add flake support to hix #1572

Uh oh!

hamishmack commented Aug 2, 2022

Uh oh!

yvan-sraka left a comment

Uh oh!

yvan-sraka Aug 3, 2022

Uh oh!

yvan-sraka Aug 3, 2022

Uh oh!

yvan-sraka Aug 4, 2022

Uh oh!

yvan-sraka Aug 3, 2022 •

edited

Loading

Uh oh!

yvan-sraka Aug 3, 2022

Uh oh!

hamishmack Aug 4, 2022

Uh oh!

yvan-sraka Aug 3, 2022

Uh oh!

yvan-sraka Aug 3, 2022

Uh oh!

yvan-sraka Aug 3, 2022

Uh oh!

yvan-sraka Aug 3, 2022

Uh oh!

hamishmack Aug 4, 2022

Uh oh!

yvan-sraka Aug 4, 2022

Uh oh!

Uh oh!

Add flake support to hix #1572

Add flake support to hix #1572

Uh oh!

Conversation

hamishmack commented Aug 2, 2022

Uh oh!

yvan-sraka left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yvan-sraka Aug 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yvan-sraka Aug 3, 2022 •

edited

Loading