cabalProject': Consider cabalProjectLocal even if cabalProject argument is null
#1588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…argument is null
|
Motivation? |
|
Sometimes you want to use |
|
Yes this is a bug. I thought it only affected |
|
Does cabal accept a |
It does (with a warning): |
|
Do we want the same |
|
cabal only seems to print that warning when there is an error. I think we could write the |
|
Good. Then please include a note explaining that this behaviour matches cabal and we tested it. |
|
I've updated the PR |
|
bors try |
tryBuild failed: |
|
bors try is all green now. |
tryBuild failed: |
hamishmack
added a commit
that referenced
this pull request
Sep 2, 2022
#1588 does not provide an implicit project the way cabal does. So for instance: ``` $ cabal unpack hello $ cd hello-1.0.0.2 $ echo 'constraints: hello<0' >cabal.project.local $ cabal build all Resolving dependencies... Error: cabal: Could not resolve dependencies: [__0] next goal: hello (user goal) [__0] rejecting: hello-1.0.0.2 (constraint from project config /Users/hamish/iohk/hello-1.0.0.2/cabal.project.local requires <0) [__0] rejecting: hello-1.0.0.1, hello-1.0 (constraint from user target requires ==1.0.0.2) [__0] fail (backjumping, conflict set: hello) After searching the rest of the dependency tree exhaustively, these were the goals I've had most trouble fulfilling: hello ``` So even though there was no `packages:` it is looking for the package in the default location (the default is `packages: ./*.cabal` according to the cabal docs). I also checked that including `packages:` in `.local` does not change the implicit `packages: ./*.cabal` with: ``` $ cabal unpack split $ echo 'packages: ./split-0.2.3.5' > cabal.project.local $ cabal build hello:exe:hello split:lib:split ```
hamishmack
added a commit
that referenced
this pull request
Sep 2, 2022
Merged
hamishmack
added a commit
that referenced
this pull request
Sep 2, 2022
I forgot this also avoids and IFD when I suggested it could be removed. See #1588
hamishmack
added a commit
that referenced
this pull request
Sep 2, 2022
#1588 does not provide an implicit project the way cabal does. So for instance: ``` $ cabal unpack hello $ cd hello-1.0.0.2 $ echo 'constraints: hello<0' >cabal.project.local $ cabal build all Resolving dependencies... Error: cabal: Could not resolve dependencies: [__0] next goal: hello (user goal) [__0] rejecting: hello-1.0.0.2 (constraint from project config /Users/hamish/iohk/hello-1.0.0.2/cabal.project.local requires <0) [__0] rejecting: hello-1.0.0.1, hello-1.0 (constraint from user target requires ==1.0.0.2) [__0] fail (backjumping, conflict set: hello) After searching the rest of the dependency tree exhaustively, these were the goals I've had most trouble fulfilling: hello ``` So even though there was no `packages:` it is looking for the package in the default location (the default is `packages: ./*.cabal` according to the cabal docs). I also checked that including `packages:` in `.local` does not change the implicit `packages: ./*.cabal` with: ``` $ cabal unpack split $ echo 'packages: ./split-0.2.3.5' > cabal.project.local $ cabal build hello:exe:hello split:lib:split ```
hamishmack
added a commit
that referenced
this pull request
Sep 2, 2022
#1588 does not provide an implicit project the way cabal does. So for instance: ``` $ cabal unpack hello $ cd hello-1.0.0.2 $ echo 'constraints: hello<0' >cabal.project.local $ cabal build all Resolving dependencies... Error: cabal: Could not resolve dependencies: [__0] next goal: hello (user goal) [__0] rejecting: hello-1.0.0.2 (constraint from project config /Users/hamish/iohk/hello-1.0.0.2/cabal.project.local requires <0) [__0] rejecting: hello-1.0.0.1, hello-1.0 (constraint from user target requires ==1.0.0.2) [__0] fail (backjumping, conflict set: hello) After searching the rest of the dependency tree exhaustively, these were the goals I've had most trouble fulfilling: hello ``` So even though there was no `packages:` it is looking for the package in the default location (the default is `packages: ./*.cabal` according to the cabal docs). I also checked that including `packages:` in `.local` does not change the implicit `packages: ./*.cabal` with: ``` $ cabal unpack split $ echo 'packages: ./split-0.2.3.5' > cabal.project.local $ cabal build hello:exe:hello split:lib:split ```
hamishmack
added a commit
that referenced
this pull request
Sep 2, 2022
#1588 does not provide an implicit project the way cabal does. So for instance: ``` $ cabal unpack hello $ cd hello-1.0.0.2 $ echo 'constraints: hello<0' >cabal.project.local $ cabal build all Resolving dependencies... Error: cabal: Could not resolve dependencies: [__0] next goal: hello (user goal) [__0] rejecting: hello-1.0.0.2 (constraint from project config /Users/hamish/iohk/hello-1.0.0.2/cabal.project.local requires <0) [__0] rejecting: hello-1.0.0.1, hello-1.0 (constraint from user target requires ==1.0.0.2) [__0] fail (backjumping, conflict set: hello) After searching the rest of the dependency tree exhaustively, these were the goals I've had most trouble fulfilling: hello ``` So even though there was no `packages:` it is looking for the package in the default location (the default is `packages: ./*.cabal` according to the cabal docs). I also checked that including `packages:` in `.local` does not change the implicit `packages: ./*.cabal` with: ``` $ cabal unpack split $ echo 'packages: ./split-0.2.3.5' > cabal.project.local $ cabal build hello:exe:hello split:lib:split ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't tested this.