Docs improvements #171
Merged
Docs improvements #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rvl
commented
Jun 10, 2019
rvl
commented
- Dev note about nixpkgs pin
- More information about selecting a GHC version for cabal projects @nomeata.
- A little bit more information about cross compiling, but this is still incomplete.
angerman
reviewed
Jun 10, 2019
docs/user-guide/cross-compilation.md
Outdated
| project = import ./default.nix; | ||
| pkgs = import <nixpkgs> {}; | ||
| native = import project { inherit pkgs; }; | ||
| crossRasperryPi = import project { pkgs = pkgs.pkgsCross.raspberryPi; }; |
There was a problem hiding this comment.
Yey, another nixpkgs indirection. Not sure if being explicit in using import <nixpkgs> { crossSystem = ...; } would be better. I'm always afraid that those abstractions make it even harder for someone new to nix to understand what is going on :-/
There was a problem hiding this comment.
Yeah maybe, the pkgsCross thing is pretty magic. I have changed it to use crossSystem and added an explanation.
angerman
approved these changes
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.