better pkg config path for devshell + access to variants from project #1760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that manually going through pkg-config of all packages. Also filter out non-derivation from nativeBuildInputs.
jbgi
force-pushed
the
devshell-better-pkg-config-path
branch
from
c83fba5 to
711d6e1
Compare
jbgi
force-pushed
the
devshell-better-pkg-config-path
branch
from
711d6e1 to
7fa35bf
Compare
|
No opinion on the variants stuff, I'm still on team functions. Could we also split out the devshell code into a simple function? AFAICT it only uses |
jbgi
force-pushed
the
devshell-better-pkg-config-path
branch
3 times, most recently
from
42ddb6e to
97cd059
Compare
jbgi
force-pushed
the
devshell-better-pkg-config-path
branch
from
97cd059 to
88821e4
Compare
|
@michaelpj done in last commit. |
michaelpj
approved these changes
Oct 21, 2022
|
bors try |
tryBuild succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.