Fix aarch64-linker, take 2 #1791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are these patches in GHC? |
No. They would be against 8.10.7, and there's not going to be a 8.10.8 release is all likelihood. 9.6 has a better m32 allocator for windows that does high mem as well. We should use that there. I'll need to check if the mem corruption bug is present in master though. With a 9.2 compatible node, we should be able to see if the same issue still arise there. |
|
I don't get why ci/ciJobs.x86_64-linux.required-unstable-ghc8107-aarch64-multiplatform fails. |
That job just built fine on the agent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one moves most of the allocation logic into the m32 allocator, while also completely ignoring the lower requirement. This of course is not ideal, however we've been mapping pages at the oder of 100x (4096 vs 40) the required space, and thus often ran out of memory due to sections per function.
This is now much improved. It also revealed at least one out-of-bounds memory write issue.