Skip to content

Fix evalDeps package ids with - in name #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 11, 2020
Merged

Fix evalDeps package ids with - in name #585

merged 14 commits into from
May 11, 2020

Conversation

hamishmack
Copy link
Collaborator

@hamishmack hamishmack commented May 6, 2020

Instead of just striping off the version number from the end of each package sed is removing all the - characters as well. This bug was corrected here, but not here.

I am not sure what this would have broken downstream (if anything), but it causes errors in the log like this:

js-unknown-ghcjs-ghc-pkg: cannot find package ghcboot
js-unknown-ghcjs-ghc-pkg: cannot find package ghcbootth
js-unknown-ghcjs-ghc-pkg: cannot find package ghccompact
js-unknown-ghcjs-ghc-pkg: cannot find package ghcheap
js-unknown-ghcjs-ghc-pkg: cannot find package ghcprim
js-unknown-ghcjs-ghc-pkg: cannot find package ghcjsprim
js-unknown-ghcjs-ghc-pkg: cannot find package ghcjsth
js-unknown-ghcjs-ghc-pkg: cannot find package integergmp

@hamishmack hamishmack requested a review from angerman May 6, 2020 10:03
@angerman
Copy link
Collaborator

angerman commented May 6, 2020

LGTM

@hamishmack hamishmack marked this pull request as ready for review May 11, 2020 11:49
@hamishmack hamishmack merged commit 71f31ce into master May 11, 2020
@iohk-bors iohk-bors bot deleted the hkm/pkg-id-fix branch May 11, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants