Rename pkg-def-overlays to pkg-def-extras #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qrilka
reviewed
Mar 4, 2019
docs/iohk-nix.md
Outdated
| @@ -74,7 +74,7 @@ let | |||
| # The overlay allows extension or restriction of the set of | |||
| # packages we are interested in. By using the stack-pkgs.overlay | |||
There was a problem hiding this comment.
Shouldn't the lines above not include "overlay" as well?
There was a problem hiding this comment.
This one should go.
docs/iohk-nix.md
Outdated
| @@ -74,7 +74,7 @@ let | |||
| # The overlay allows extension or restriction of the set of | |||
| # packages we are interested in. By using the stack-pkgs.overlay | |||
| # we restrict our package set to the ones provided in stack.yaml. | |||
| pkg-def-overlays = [ | |||
| pkg-def-extras = [ | |||
| stack-pkgs.overlay | |||
| iohk-overlay.${compiler} | |||
There was a problem hiding this comment.
Right. But that's probably going to be as second step. As the stack-pkgs.overlay is generated by the stack-to-nix tool from input-output-hk/nix-tools.
docs/user-guide.md
Outdated
| @@ -83,7 +83,7 @@ let | |||
| pkgSet = haskell.mkPkgSet { | |||
| inherit pkgs; | |||
| pkg-def = my-pkgs.pkg-def; | |||
| pkg-def-overlays = [ | |||
| pkg-def-extras = [ | |||
| # this overlay will provide additional packages | |||
There was a problem hiding this comment.
Yep, that should go :-)
rvl
approved these changes
Mar 10, 2019
|
I pushed a fix for my merge conflict. Shame we can't yet supply |
angerman
force-pushed
the
feature/pkg-def-extras
branch
from
116bb3a to
95ff192
Compare
andreabedini
pushed a commit
to andreabedini/haskell.nix
that referenced
this pull request
Sep 14, 2022
this decreases hackage.nix loading time by approximately 5x (to 0.3s), dropping my evaluation time from 8s to 6s in total
andreabedini
pushed a commit
to andreabedini/haskell.nix
that referenced
this pull request
Sep 14, 2022
this decreases hackage.nix loading time by approximately 5x (to 0.3s), dropping my evaluation time from 8s to 6s in total
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75