Pin nixpkgs to latest nixos-19.03 #98
Conversation
rvl
force-pushed
the
rvl/nixpkgs-pin
branch
4 times, most recently
from
a7fa8cb to
1c3be2d
Compare
| { pkgs ? import <nixpkgs> {} | ||
| { pkgs ? import nixpkgs {} | ||
| # Use a pinned nixpkgs rather than the one on NIX_PATH | ||
| , nixpkgs ? ./nixpkgs |
There was a problem hiding this comment.
Why not do this the same as the other pins below?
There was a problem hiding this comment.
The other pins (hackage and stackage) can be overridden with a json file because that will be a fairly common thing to do for users -- running nix-prefetch-git to select a more recent revision of hackage or stackage from github.
For the pkgs/nixpkgs args I want to use the "normal" pattern for pinning.
|
I think this is fine, although probably clients should pass in whatever nixpkgs they're using as an argument. e.g. in It might be fine not to do this, but I would worry about e.g. a package built with |
|
Alas the CI is failing because |
I plan to delete the auto-generated nix expressions in nix-tools so that it is a pure cabal project.
|
I have |
…is locked) (input-output-hk#98) * Fix stack-to-nix: .stack-to-nix.cache: openFile: resource busy (file is locked) * Use deepseq fmap instead of seq fmap * niv update haskell.nix * Fix for buildkite Co-authored-by: Samuel Evans-Powell <[email protected]> Co-authored-by: Hamish Mackenzie <[email protected]>
…is locked) (input-output-hk#98) * Fix stack-to-nix: .stack-to-nix.cache: openFile: resource busy (file is locked) * Use deepseq fmap instead of seq fmap * niv update haskell.nix * Fix for buildkite Co-authored-by: Samuel Evans-Powell <[email protected]> Co-authored-by: Hamish Mackenzie <[email protected]>
This will fix the Hydra build, and ensure Buildkite and others can use cached builds of nix-tools.
I am not 100% certain what do do about pinning nixpkgs. This change means that users'
<nixpkgs>is ignored. Maybe that's a good thing - for example, nix-tools depends on aghc844attribute that is not available in some versions of nixpkgs (see #70).