Skip to content

coot/bolt12/monad trace mvar #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Conversation

coot
Copy link
Collaborator

@coot coot commented May 16, 2025

Subsumes #212.

@coot coot requested a review from Copilot May 16, 2025 08:37
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements tracing support for MVars in the IOSim and related STM interfaces while renaming the InspectMonad type to InspectMonadSTM.

  • Added the MonadTraceMVar instance and corresponding traceMVarIO function in IOSim and IO instances.
  • Updated various trace functions across multiple files to use the new InspectMonadSTM type.
  • Adjusted the cabal.project file to change the GHC version requirement.

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
io-sim/src/Control/Monad/IOSim/Types.hs Added InstanceSigs pragma, implemented MonadTraceMVar instance, and renamed InspectMonad to InspectMonadSTM.
io-sim/src/Control/Monad/IOSim/STM.hs Updated trace functions’ type signatures to use InspectMonadSTM.
io-sim/CHANGELOG.md Updated release notes to reflect the new tracing functionality and name change.
io-classes/strict-stm/Control/Concurrent/Class/MonadSTM/Strict/TVar.hs Updated type signatures to use InspectMonadSTM.
io-classes/strict-stm/Control/Concurrent/Class/MonadSTM/Strict/TQueue.hs Revised trace function signatures to use InspectMonadSTM.
io-classes/strict-stm/Control/Concurrent/Class/MonadSTM/Strict/TMVar.hs Modified traceTMVar type signature to use InspectMonadSTM.
io-classes/strict-stm/Control/Concurrent/Class/MonadSTM/Strict/TBQueue.hs Updated traceTBQueue signatures to use InspectMonadSTM.
io-classes/src/Control/Monad/Class/MonadSTM/Internal.hs Renamed InspectMonad to InspectMonadSTM across several trace functions.
io-classes/src/Control/Concurrent/Class/MonadMVar.hs Added the MonadTraceMVar class and instance for IO.
io-classes/mtl/Control/Monad/Class/MonadSTM/Trans.hs Updated MonadInspectSTM instances to use the new InspectMonadSTM alias.
io-classes/CHANGELOG.md Documented the breaking change and addition of the MonadTraceMVar.
cabal.project Updated the GHC version constraint from 9.12 to 9.10.2.

@coot coot force-pushed the coot/bolt12/monad-trace-mvar branch from dfa09e6 to 8e541cf Compare May 16, 2025 08:38
@coot coot closed this May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants