Add Prometheus labels for Cardano build info display #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgmeier
reviewed
May 13, 2024
| Label l -> trace ("renderSamples " <> T.unpack l) $ | ||
| if "{" `T.isPrefixOf` l | ||
| then renderLabel sk l | ||
| else renderNamedValue sk (byteString $ encodeUtf8 l) | ||
| _ -> mempty |
| Label l -> if isFloat l | ||
| then renderNamedValue sk (byteString $ encodeUtf8 l) | ||
| else mempty | ||
| Label l -> trace ("renderSamples " <> T.unpack l) $ |
There was a problem hiding this comment.
What happened to the mempty result when isFloat is False? We should leave that behaviour unchanged.
There was a problem hiding this comment.
Okay I revert it (so the secret treasures will never be seen :)
mgmeier
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the Cardano build info display by adding support for Prometheus labels. By incorporating Prometheus labels into the build info metrics, we improve monitoring and observability capabilities for Cardano nodes.
This is a restricted solution, which allows metrics with labels only with a value of 1.