Skip to content

Make it build with ghc-9.10 #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Make it build with ghc-9.10 #648

merged 3 commits into from
Aug 7, 2024

Conversation

erikd
Copy link
Member

@erikd erikd commented Aug 7, 2024

description

  • Make if build with ghc-9.10

checklist

  • compiles (cabal v2-build or stack build)
  • tests run successfully (cabal v2-test or stack test)
  • documentation added
  • link to an issue
  • add milestone (the current sprint)

@erikd erikd changed the title Make it build with gch-9.10 Make it build with ghc-9.10 Aug 7, 2024
@angerman
Copy link
Contributor

angerman commented Aug 7, 2024

Darwin for 8.10.7 has been broken since d7e2556. I don't think this PR should be blocked on that. We should have a separate PR trying to rectify the darwin situation. But I'd argue it's out of scope for this.

@erikd erikd self-assigned this Aug 7, 2024
@erikd erikd enabled auto-merge August 7, 2024 05:18
Copy link
Contributor

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGtM

@erikd erikd added this pull request to the merge queue Aug 7, 2024
Merged via the queue into master with commit 60b1ce9 Aug 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants