Skip to content

feat: add simple version of asset input [LW-9231] #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

DominikGuzei
Copy link
Member

This PR adds a simple version of the AssetInput matching the existing API as closely as possible. This is required for the send flow form in Lace Beta (Midnight), as defined in https://input-output.atlassian.net/browse/LW-9231

image

@DominikGuzei DominikGuzei added the enhancement New feature or request label Oct 7, 2024
@DominikGuzei DominikGuzei self-assigned this Oct 7, 2024
Copy link
Contributor

@szymonmaslowski szymonmaslowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ! I am leaving some comments.

@DominikGuzei DominikGuzei force-pushed the feat/lw-9231-add-simple-asset-input branch from f8ab3ee to 4ed8e0d Compare October 9, 2024 07:23
@DominikGuzei
Copy link
Member Author

@pczeglik-iohk @szymonmaslowski thanks for the in-depth review 🙏 all issues should be fixed in the latest commit

@DominikGuzei DominikGuzei force-pushed the feat/lw-9231-add-simple-asset-input branch from 4ed8e0d to f3ca7f1 Compare October 9, 2024 10:32
Copy link

sonarqubecloud bot commented Oct 9, 2024

Copy link
Collaborator

@pczeglik-iohk pczeglik-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @DominikGuzei 🎸

@DominikGuzei DominikGuzei merged commit 697137b into main Oct 10, 2024
3 checks passed
@DominikGuzei DominikGuzei deleted the feat/lw-9231-add-simple-asset-input branch October 10, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants