[ETCM-1066] Add EIP-2929 VM integration tests #1104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasz-golebiewski
force-pushed
the
feature/etcm-1066/vm-integration-tests
branch
from
e1b4500 to
3064cca
Compare
strauss-m
approved these changes
Aug 19, 2021
| @@ -203,13 +210,13 @@ class OpCodeGasSpecPostEip2929 extends AnyFunSuite with OpCodeTesting with Match | |||
| val table = Table[UInt256, UInt256, Boolean, BigInt, BigInt]( | |||
| ("offset", "value", "alreadyAccessed", "startGas", "expectedGasConsumption"), | |||
| (0, 1, true, G_callstipend + 1, G_sload), | |||
| (0, 1, false, G_sload + G_cold_account_access, G_sload + G_cold_account_access), | |||
| (0, 1, false, G_callstipend + 1, G_sload + G_cold_sload), | |||
There was a problem hiding this comment.
I was wondering why the '+1' here, but the yellow paper answered me: the call will fail if there is less than or EQUALS to G_callstipend gas left.
There was a problem hiding this comment.
I wonder if we should start adding such tidbits of knowledge into the codebase.
//YP, page X, "quote"
lukasz-golebiewski
force-pushed
the
feature/etcm-1066/vm-integration-tests
branch
from
3064cca to
21960c6
Compare
dzajkowski
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds tests for gas changes introduced in EIP-2929 that span across multiple opcodes
Also fixes a bug in which
G_cold_account_accesswas charged incorrectly for storage access instead ofG_cold_sload