[MPT] Test partitioning in order not to ignore long running tests #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whysoserious
approved these changes
Jan 18, 2017
whysoserious
suggested changes
Jan 18, 2017
|
@whysoderious I rather to to that change in the main MPT branch but it can do it here if you want to |
|
No worries, feel free to merge it.
…On Jan 18, 2017 4:28 PM, "Alan Verbner" ***@***.***> wrote:
@whysoderious I rather to to that change in the main MOST branch but it
can do it here if you want to
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABC-VmoyHDGAZ-7LUt1_0xUj15dpCF03ks5rTi-JgaJpZM4Lm95K>
.
|
LukasGasior1
pushed a commit
that referenced
this pull request
Feb 15, 2019
GMC-136 Reconcile master (websocket patches)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to avoid long running tests to be ignored (or bother local executions) we decided to split them in two different configurations. Test can be run as:
sbt testwill run faster testssbt it:testwill run benchmark and integration tests that take more time to runitconfiguration was based onTestto be able to shareObjectGeneratorsand maybe any other test utils class. Please let me know if you don't like it.I also created an
EphemDataSourceas after several discussions this will be needed besides tests. We can create a custom for testing purposes in the future. Will add tests for this and IodbDataSource once this PR is merged.