Add universal configuration for a custom private testnet #441
Conversation
loverdos
force-pushed
the
feature/cgkiele-155
branch
2 times, most recently
from
1da1af6 to
e5a64d5
Compare
|
Note: this should be merged after #442 and include the following settings: |
loverdos
force-pushed
the
feature/cgkiele-155
branch
4 times, most recently
from
7b53ca6 to
b1fb023
Compare
| def parseNode(id_host_port: String): AtomixNode = { | ||
| val parts = id_host_port.split(":") | ||
| log.info(s"atomix-raft: id_host_port = ${id_host_port} => parts = ${parts.toList}") |
There was a problem hiding this comment.
Minor: not sure if it's the best place for such logging, as a reader might expect this to be a pure function and want to use it in different context.
There was a problem hiding this comment.
hahha... this is just a transient commit I needed for quickly testing the cluster, so this logging is going to go away. But we are still in do-no-merge mode ;)
| @@ -45,8 +45,10 @@ object AtomixRaftConfig extends Logger { | |||
| case _ ⇒ throw new IllegalArgumentException("parts.length != 1, 2, 3") | |||
| } | |||
|
|
|||
| //noinspection ScalaStyle | |||
| discovery { | ||
| # Listening interface for discovery protocol | ||
| interface = ${mantis.network.server-address.interface} | ||
| } |
There was a problem hiding this comment.
I think we should disable discovery and override bootstrap nodes
| interface = ${mantis.network.server-address.interface} | ||
|
|
||
| # Domains allowed to query RPC endpoint. Use "*" to enable requests from any domain. | ||
| cors-allowed-origins = [] |
There was a problem hiding this comment.
I wonder if we should set this to "*"
There was a problem hiding this comment.
Yes, I changed this to match exactly what we do now in the testnet, which is actually the primary motivation for this PR.
loverdos
changed the title
loverdos
force-pushed
the
feature/cgkiele-155
branch
2 times, most recently
from
1fa91fe to
893fe02
Compare
| network { | ||
| discovery { | ||
| # Turn discovery of/off | ||
| # discovery-enabled = true |
There was a problem hiding this comment.
So, don't we want that disabled?
loverdos
force-pushed
the
feature/cgkiele-155
branch
from
893fe02 to
43da580
Compare
loverdos
force-pushed
the
feature/cgkiele-155
branch
from
43da580 to
cfd8a6f
Compare
| # Set of initial nodes | ||
| bootstrap-nodes = [ | ||
| "enode://18a551bee469c2e02de660ab01dede06503c986f6b8520cb5a65ad122df88b17b285e3fef09a40a0d44f99e014f8616cf1ebc2e094f96c6e09e2f390f5d34857@127.0.0.1:30303", | ||
| ] |
There was a problem hiding this comment.
Minor, as it will have to be modified anyway, but wouldn't we prefer empty list or even:
bootstrap-nodes = [
# fill in with node URIs for the private network, e.g.:
# "enode://18a551bee469c2e02de660ab01dede06503c986f6b8520cb5a65ad122df88b17b285e3fef09a40a0d44f99e014f8616cf1ebc2e094f96c6e09e2f390f5d34857@127.0.0.1:30303"
]
No description provided.