Skip to content

[CGKIELE-168] Add support for metrics #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2018
Merged

Conversation

loverdos
Copy link
Contributor

@loverdos loverdos commented May 2, 2018

No description provided.

@loverdos loverdos force-pushed the feature/metrics branch 2 times, most recently from 2751bac to e54ffef Compare May 3, 2018 08:48
@loverdos loverdos force-pushed the feature/metrics branch 5 times, most recently from 5371c3b to 4901cb3 Compare May 10, 2018 09:27
@loverdos loverdos requested review from LukasGasior1 and rtkaczyk May 15, 2018 08:52
Copy link
Contributor

@LukasGasior1 LukasGasior1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

# subsequent requests are blocked until the queue has room again.
queue-size = 1024

# Iff true, any errors during metrics client operations will be logged.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iff - do you mean "if and only if" or is it a typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-D

Copy link
Contributor

@rtkaczyk rtkaczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pending conflict resolution

We implement the necessary infrastructure for exposing application
metrics and provide the first set of them. In particular, we expose
the following:

* `start.event` is a delta signal emitted on startup
* `stop.event` is a delta signal emitted on shutdown
* `ledger.import.block.number` counts the highest block number, as
  imported in Ledger (`Ledger.importBlock()`).
@loverdos loverdos merged commit bb5c096 into phase/iele_testnet May 15, 2018
@rtkaczyk rtkaczyk deleted the feature/metrics branch May 15, 2018 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants