[ETCM-49] Replace statsd metrics with prometheus #668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirkoAlic
force-pushed
the
ETCM-49-Replace-statsd-metrics-with-prometheus
branch
2 times, most recently
from
6271adf to
3e23224
Compare
mirkoAlic
force-pushed
the
ETCM-49-Replace-statsd-metrics-with-prometheus
branch
from
3e23224 to
7851d30
Compare
mirkoAlic
force-pushed
the
ETCM-49-Replace-statsd-metrics-with-prometheus
branch
from
83ba14b to
ebc0d7c
Compare
mirkoAlic
force-pushed
the
ETCM-49-Replace-statsd-metrics-with-prometheus
branch
from
ebc0d7c to
cf151db
Compare
mmrozek
reviewed
Sep 17, 2020
| import io.micrometer.jmx.JmxConfig | ||
|
|
||
| class AppJmxConfig extends JmxConfig { | ||
| def get(key: String): String = null |
There was a problem hiding this comment.
yes (override is missing, i will add it)
| import scala.util.Try | ||
|
|
||
| case class Metrics(metricsPrefix: String, registry: MeterRegistry, serverPort: Int = 0) { | ||
| private[this] final val MetricsPrefixDot = metricsPrefix + "." |
There was a problem hiding this comment.
The same logic is used in meterRegistryBuilder maybe it could be reused
| case class Metrics(metricsPrefix: String, registry: MeterRegistry, serverPort: Int = 0) { | ||
| private[this] final val MetricsPrefixDot = metricsPrefix + "." | ||
|
|
||
| private[this] def mkName(name: String): String = |
… into ETCM-49-Replace-statsd-metrics-with-prometheus Conflicts: build.sbt src/main/scala/io/iohk/ethereum/network/p2p/messages/PV62.scala src/universal/conf/logback.xml src/main/scala/io/iohk/ethereum/domain/BlockBody.scala TODO: Regenerate nix dependencies
…repo.nix files, sbtnix is inyecting local paths)
mirkoAlic
added
the
update dependencies
mirkoAlic
deleted the
ETCM-49-Replace-statsd-metrics-with-prometheus
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
in order to follow IOHK devops standards we will move our metrics to Prometheus (Pull monitoring model) + Grafana.
Important Changes Introduced
Testing
In order to run it locally using docker monitoring client please check the README.md#Monitoring