[CHORE] BlockchainConfig as a case class #674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mirkoAlic
reviewed
Sep 16, 2020
| @@ -43,6 +43,8 @@ object ScenarioSetup { | |||
|
|
|||
| abstract class ScenarioSetup(_vm: VMImpl, scenario: BlockchainScenario) { | |||
|
|
|||
| import BlockchainTestConfig._ | |||
There was a problem hiding this comment.
It is, as baseBlockchainConfig and withSkippedPoWValidationBlockchainConfig functions use the BlockchainConfig's defined there
mirkoAlic
reviewed
Sep 16, 2020
| @@ -172,43 +172,43 @@ class EtcHandshakerSpec extends FlatSpec with Matchers { | |||
| override val appStateStorage: AppStateStorage = TestSetup.this.storagesInstance.storages.appStateStorage | |||
| } | |||
|
|
|||
| override lazy val blockchainConfig = new BlockchainConfig { | |||
| override lazy val blockchainConfig = BlockchainConfig ( | |||
There was a problem hiding this comment.
(minor) I guess here you could use the blockchainConfig.copy given EphemBlockchainTestSetup has access to default instance.
…e/blockchainconfig-as-caseclass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes BlockchainConfig from being a trait to a case class.
As seen on a couple of examples here, this will: