Skip to content

[CHORE] Refactor dependencies, update scalacheck #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 18, 2020

Conversation

mmrozek
Copy link
Contributor

@mmrozek mmrozek commented Sep 16, 2020

Description

  • Move dependencies to separate file
  • update scalacheck

CAUTION: a majority of changes is caused by renaming of PropertyChecks trait and formatting all touched files. Please don't be afraid ;)

@mmrozek mmrozek force-pushed the refactor-dependencies branch from f79f14c to bfc624b Compare September 17, 2020 06:47
repo.nix Outdated
"nix-public" = "";
"nix-rocksDb" = "";
};
"artifacts" = {
"nix-local-preloaded/file:/Users/mmrozek/.sbtix/preloaded/com/trueaccord/lenses/lenses_2.12/0.4.12/lenses_2.12-0.4.12.jar" = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=/

@mirkoAlic
Copy link
Contributor

mirkoAlic commented Sep 17, 2020

Fix nix build is still needed, but apart from that, LGTM!

@mirkoAlic mirkoAlic added the update dependencies notify if is required to update nix dependencies or run sbt clean before compile the code label Sep 17, 2020
sevanspowell and others added 4 commits September 18, 2020 17:18
…b.com/input-output-hk/mantis into refactor-dependencies

� Conflicts:
�	build.sbt
�	project/Dependencies.scala
�	src/test/scala/io/iohk/ethereum/consensus/BlockGeneratorSpec.scala
Copy link
Contributor

@kapke kapke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing and look good to me!

build.sbt Outdated
val circeVersion = "0.9.3"
val rocksDb = "6.11.4"
// Resolver for rocksDb
resolvers += "rocksDb" at "https://dl.bintray.com/ethereum/maven/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove it now, see 56e9336

@@ -229,6 +229,8 @@ mantis {
# Declaring the protocol here means that a more protocol-specific configuration
# is pulled from the corresponding consensus implementation.
# For example, in case of ethash, a section named `ethash` is used.
# Available protocols: ethash, mocked
# In case of mocked, remember to enable qa api
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mirkoAlic mirkoAlic merged commit 68dfe36 into develop Sep 18, 2020
@mirkoAlic mirkoAlic deleted the refactor-dependencies branch September 18, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update dependencies notify if is required to update nix dependencies or run sbt clean before compile the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants