-
Notifications
You must be signed in to change notification settings - Fork 75
[CHORE] Refactor dependencies, update scalacheck #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f79f14c
to
bfc624b
Compare
…b.com/input-output-hk/mantis into refactor-dependencies � Conflicts: � build.sbt
…b.com/input-output-hk/mantis into refactor-dependencies � Conflicts: � src/test/scala/io/iohk/ethereum/consensus/validators/BlockHeaderValidatorSpec.scala
repo.nix
Outdated
"nix-public" = ""; | ||
"nix-rocksDb" = ""; | ||
}; | ||
"artifacts" = { | ||
"nix-local-preloaded/file:/Users/mmrozek/.sbtix/preloaded/com/trueaccord/lenses/lenses_2.12/0.4.12/lenses_2.12-0.4.12.jar" = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
=/
Fix nix build is still needed, but apart from that, LGTM! |
…b.com/input-output-hk/mantis into refactor-dependencies � Conflicts: � build.sbt
…b.com/input-output-hk/mantis into refactor-dependencies � Conflicts: � build.sbt � project/Dependencies.scala � src/test/scala/io/iohk/ethereum/consensus/BlockGeneratorSpec.scala
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor thing and look good to me!
build.sbt
Outdated
val circeVersion = "0.9.3" | ||
val rocksDb = "6.11.4" | ||
// Resolver for rocksDb | ||
resolvers += "rocksDb" at "https://dl.bintray.com/ethereum/maven/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove it now, see 56e9336
@@ -229,6 +229,8 @@ mantis { | |||
# Declaring the protocol here means that a more protocol-specific configuration | |||
# is pulled from the corresponding consensus implementation. | |||
# For example, in case of ethash, a section named `ethash` is used. | |||
# Available protocols: ethash, mocked | |||
# In case of mocked, remember to enable qa api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
CAUTION: a majority of changes is caused by renaming of
PropertyChecks
trait and formatting all touched files. Please don't be afraid ;)