Skip to content

[ETCM-125] Fix faucet logging issue #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Sep 23, 2020
Merged

[ETCM-125] Fix faucet logging issue #693

2 commits merged into from
Sep 23, 2020

Conversation

mmrozek
Copy link
Contributor

@mmrozek mmrozek commented Sep 23, 2020

Description

Add missing logging configuration to the faucet.
Fix faucet dir path

@mmrozek mmrozek added bug Something isn't working BREAKS CONFIG Affects the default configuration labels Sep 23, 2020
@mmrozek mmrozek requested review from kapke, ntallar and a user September 23, 2020 12:36
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kapke kapke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like that part of configuration is not scoped anymore. I get the reason though so I won't block this PR.

@ghost ghost merged commit b8adef4 into develop Sep 23, 2020
@ghost ghost deleted the fix-faucet-logging-issue branch September 23, 2020 14:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKS CONFIG Affects the default configuration bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants