Skip to content

[Chore] Jvm flags #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2020
Merged

[Chore] Jvm flags #727

merged 2 commits into from
Oct 14, 2020

Conversation

ntallar
Copy link

@ntallar ntallar commented Oct 9, 2020

Description

Copies .jvmopts JVM flag from the other project, without them, generating the DAG (by running node with sbt run) always resulted in java.lang.OutOfMemoryError: GC overhead limit exceeded errors

Testing

Running a node with ethash configured and mining enabled (without a DAG already generated) should work successfully

@ntallar ntallar requested review from kapke and mirkoAlic October 9, 2020 17:41
@ntallar ntallar marked this pull request as ready for review October 9, 2020 17:41
Copy link
Contributor

@kapke kapke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ntallar ntallar merged commit d982b1f into develop Oct 14, 2020
@ntallar ntallar deleted the chore/jvm-flags branch October 14, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants