[ETCM-286] Adjustments to rpc tests #776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we could add this as part of the buildkite flow? |
mirkoAlic
reviewed
Nov 6, 2020
| @@ -899,7 +899,7 @@ class RpcApiTests extends AnyFlatSpec with Matchers with Logger { | |||
| nonExistingFilterChanges.getLogs.asScala.size shouldEqual 0 | |||
| } | |||
|
|
|||
| it should "eth_newBlockFilter" taggedAs (PrivNet, MainNet) in new ScenarioSetup { | |||
| it should "eth_newBlockFilter" taggedAs (PrivNet) in new ScenarioSetup { | |||
There was a problem hiding this comment.
i'm curious, why MainNet is not needed anymore?
There was a problem hiding this comment.
The test is flaky when used in such a big network as mainnet. I am not sure if it is because of reorgs, too big response or sth else. Testing PrivNet tests the required behaviour so it should be enough
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix rpc tests