Skip to content

[Chore] request logged only if it doesn't have sensible information #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2020
Merged

[Chore] request logged only if it doesn't have sensible information #825

merged 2 commits into from
Dec 2, 2020

Conversation

biandratti
Copy link
Contributor

Description

request logged only if it doesn't have sensible information

Proposed Solution

If the request method is “personal”, we only log the next legend "sensitive information"

@biandratti biandratti requested a review from ntallar December 2, 2020 12:57
ntallar
ntallar approved these changes Dec 2, 2020
View reviewed changes
Copy link

@ntallar ntallar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

 .\\            //.
. \ \          / /.
.\  ,\     /` /,.-
 -.   \  /'/ /  .
 ` -   `-'  \  -
   '.       /.\`
      -    .-
      :`//.'
      .`.'
      .' BP

@ntallar ntallar merged commit 4fc1d4a into develop Dec 2, 2020
@ntallar ntallar deleted the feature-json-rpc-error-with-sensible-log branch December 2, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntallar ntallar ntallar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biandratti @ntallar